Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2196 - Added ARKA wrapper as sub package #110

Merged
merged 3 commits into from
Mar 20, 2024
Merged

PRO-2196 - Added ARKA wrapper as sub package #110

merged 3 commits into from
Mar 20, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added ARKA apis as a sub package module

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Mar 18, 2024

PRO-2196 Create a subpackage for Arka backend API

ch4r10t33r
ch4r10t33r requested changes Mar 18, 2024
View reviewed changes
src/sdk/paymaster/provider/arka.ts Show resolved Hide resolved
src/sdk/paymaster/provider/arka.ts Outdated Show resolved Hide resolved
ch4r10t33r
ch4r10t33r approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kaushalrajbacancy
kaushalrajbacancy approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@kaushalrajbacancy kaushalrajbacancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit 658f675 into master Mar 20, 2024
5 of 6 checks passed
@vignesha22 vignesha22 deleted the PRO-2196-Arka_SubPackage branch March 20, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@kaushalrajbacancy kaushalrajbacancy kaushalrajbacancy approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@lbw33 lbw33 Awaiting requested review from lbw33

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vignesha22 @ch4r10t33r @kaushalrajbacancy