Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2356 - Ancient8 network support #115

Merged
merged 3 commits into from
Apr 29, 2024
Merged

PRO-2356 - Ancient8 network support #115

merged 3 commits into from
Apr 29, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Removed Goerli, Op Goerli, Arb Goerli, Mumbai, Klaytn since its deprecated and Added OP Sepolia, Arb Sepolia and Ancient8 mainnet and testnet as networks supported

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Apr 29, 2024

PRO-2356 Include Ancient8 in prime sdk

ch4r10t33r
ch4r10t33r approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaushalrajbacancy
kaushalrajbacancy approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@kaushalrajbacancy kaushalrajbacancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arddluma
arddluma requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind removing Arbitrum goerli bundler url from the existing config and add Amoy support as well ?

@vignesha22 vignesha22 merged commit 53d419b into master Apr 29, 2024
6 checks passed
@vignesha22 vignesha22 deleted the PRO-2356-Ancient8_Network_Support branch April 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushalrajbacancy kaushalrajbacancy kaushalrajbacancy approved these changes

@lbw33 lbw33 lbw33 approved these changes

@arddluma arddluma arddluma approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vignesha22 @ch4r10t33r @arddluma @lbw33 @kaushalrajbacancy