You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This refactoring would reduce the code maintenance and solve some decoding issues.
During the code review of his PR, I noticed that some checks were removed, I tried to put them again, tests failed.
Since there are a lot of changes in this PR,I restarted from develop branch and introduced a minimalist change with json_annotation.
I also notice that there will be an issue with Event.from() since id is generated by getEventId() which need a late initialization that seem not compatible with this json_annotation, see LateInitializationError: Field 'id' has not been initialized.
We need to find why json_annotation is introducing a side effect on the getEventId() function which makes generates wrongs id that triggers the assertions.
We also have to find how to deal with the Event.from() and late id since this function makes really handy to create and event without generating his id and sig
The text was updated successfully, but these errors were encountered:
@ethicnology regarding to your issues im have updated the branch
There was breaking change that contructors where changed from positioned params to named params. I still thinks that positioned params are better, but to make this marge less breaking i changed it to positioned params for now
Regarding to failing events, i found that the tests were wrong.
Currently the asserts are not called in main branch in those two tests which failed in my branch. In my branch are asserts now called so its making it more bullet proof. Seems that the event pushed to code was also wrong, i tried 5 different events and all went ok. Maybe @ethicnology can you verify that event, i was not able to find it on my relays.
@ryzizub proposed json_annotation in #4 and #10
This refactoring would reduce the code maintenance and solve some decoding issues.
During the code review of his PR, I noticed that some checks were removed, I tried to put them again, tests failed.
Since there are a lot of changes in this PR,I restarted from
develop
branch and introduced a minimalist change with json_annotation.This is the commit to solve: aec073a
Tests are failing on these two assert since the id produced by
getEventId()
does not match the provided (valid) id:I also notice that there will be an issue with
Event.from()
sinceid
is generated bygetEventId()
which need alate
initialization that seem not compatible with this json_annotation, seeLateInitializationError: Field 'id' has not been initialized.
We need to find why json_annotation is introducing a side effect on the
getEventId()
function which makes generates wrongs id that triggers the assertions.We also have to find how to deal with the
Event.from()
andlate id
since this function makes really handy to create and event without generating hisid
andsig
The text was updated successfully, but these errors were encountered: