Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event tags parsing #9

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

ryzizub
Copy link
Contributor

@ryzizub ryzizub commented Jan 26, 2023

fix for #8

test/event_test.dart Outdated Show resolved Hide resolved
@ryzizub ryzizub changed the title event tags parsing fix fix: event tags parsing Jan 27, 2023
@ethicnology
Copy link
Owner

ethicnology commented Jan 27, 2023

@ryzizub Thank you, may i ask for a unit test that verify that your change is handling this particular case for a future refactoring (#11)

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Base: 91.59% // Head: 94.36% // Increases project coverage by +2.76% 🎉

Coverage data is based on head (91c5a93) compared to base (1fad8a2).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   91.59%   94.36%   +2.76%     
==========================================
  Files           5        7       +2     
  Lines         119      142      +23     
==========================================
+ Hits          109      134      +25     
+ Misses         10        8       -2     
Impacted Files Coverage Δ
lib/src/close.dart 100.00% <100.00%> (ø)
lib/src/event.dart 98.38% <100.00%> (+3.55%) ⬆️
lib/src/message.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryzizub
Copy link
Contributor Author

ryzizub commented Jan 27, 2023

@ethicnology added in a867720

@ryzizub
Copy link
Contributor Author

ryzizub commented Jan 27, 2023

@ethicnology updated the tests, actually find out that the problem was when you decoded the json

ethicnology
ethicnology previously approved these changes Jan 27, 2023
@ethicnology
Copy link
Owner

@ryzizub Thanks for your contribution 🚀

@ethicnology ethicnology changed the base branch from main to develop January 27, 2023 21:01
@ethicnology ethicnology dismissed their stale review January 27, 2023 21:01

The base branch was changed.

@ryzizub ryzizub force-pushed the event-tags-parsing-fix branch from 91c5a93 to 2693fe6 Compare January 27, 2023 21:14
@ethicnology ethicnology merged commit f8bb2b9 into ethicnology:develop Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants