Abstract block info #105
Merged
Abstract block info #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Aug 20, 2024
qzhodl
reviewed
Aug 20, 2024
qzhodl
reviewed
Aug 27, 2024
qzhodl
approved these changes
Aug 29, 2024
iteyelmp
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mining on L2 sometimes run into "StorageContract: minedTs too small".
This could be an edge case when a blob in a new shard happens to be mined immediately after the shard is opened by
pubBlobs.The test can be done by running the following cmd with code ethstorage/es-node#187
The reason is that miningInfo is timestamped by L2 chain which has block time of 2 seconds while mine method computes minedTs with L1 blocks of 12 seconds block time.
This PR abstracts blockNumber() and blockTs() as well as getRandao, etc. for StorageContract and its L2 extender so that they can use different values and implementations.