Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed MODE_NOLOG not compiling with c++11 #21

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fixed MODE_NOLOG not compiling with c++11 #21

merged 2 commits into from
Dec 22, 2023

Conversation

4c3y
Copy link
Member

@4c3y 4c3y commented Dec 21, 2023 •
edited
Loading

MODE_NOLOG is compatible exclusively with C++17 due to its utilization of the following features:

  • std::string_view
  • std::is_integral_v (instead of std::is_integral<T>::value)
  • static_assert() without string argument

@4c3y 4c3y mentioned this pull request Dec 21, 2023
Merged
@4c3y 4c3y requested a review from mikeallenspach December 21, 2023 10:50
@4c3y 4c3y marked this pull request as ready for review December 21, 2023 10:50
@4c3y 4c3y added the bug Something isn't working label Dec 21, 2023
@4c3y 4c3y requested a review from michaelpantic December 21, 2023 11:00
@4c3y 4c3y merged commit 831f9dd into master Dec 22, 2023
3 checks passed
@4c3y 4c3y deleted the fix/nolog-c++11 branch December 22, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeallenspach mikeallenspach mikeallenspach approved these changes

@michaelpantic michaelpantic Awaiting requested review from michaelpantic

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4c3y @mikeallenspach