Log level matching refactor #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturednow takes an explicitlevelnameandlevelno. This allows 3rd-party logging framework integrations to be freed of the obligation to match stdliblogginglevels.The validation of
validate_levelnowas relaxed to just validate the type of the input, and correspondingly renamed tovalidate_level.The
DEFAULT_XXXclass attributes onLogotwere updated to preferstrand use string constants for easier reading in docs. The typing of log levels everywhere was updated to preferstrfor better compatibility with 3rd-party logging frameworks.The named logging helpers in
loggedwere updated to use string level names for better compatibility with 3rd-party logging frameworks.Needed by #28.