ATL-10: Add catch-all 404 route/page #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/router.ts
Outdated
| }, | ||
| { | ||
| path: '/', | ||
| component: DefaultVue, |
There was a problem hiding this comment.
@cesarvh - not a merge blocker but perhaps we want DefaultView instead of DefaultVue?
src/styles/hartsfield-global.scss
Outdated
| @@ -0,0 +1,3 @@ | |||
| .frosted { | |||
| background-color: #6d8cb4c3!important; | |||
There was a problem hiding this comment.
@cesarvh - That seems to be an invalid hex code. And, a space is needed after the hex code.
| :height="300" | ||
| :width="800" | ||
| class="frosted px-8 py-6 accent-border accent-text mx-auto " | ||
| > |
There was a problem hiding this comment.
@cesarvh - it seems that your "continuation indentation" rule is four spaces. I think it should be two spaces. You can enforce such rule via .eslintrc.js
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <v-container class="fill-height" style=""> | |||
| <v-container class="fill-height"> | |||
| <v-responsive class="d-flex align-center text-center fill-height "> | |||
There was a problem hiding this comment.
We have an extra space in 'class' value above.
gmerritt
added a commit
that referenced
this pull request
Feb 16, 2024
Merge pull request #17 from gmerritt/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira-secure.berkeley.edu/browse/ATL-10