Fixed getCertKid to return 8 bytes instead of seven #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @slaurenz sorry to intrude in your changes but I'm trying to understand the setup of the following repository. Apologies if you find not appropriated. I would expect that these meaningful changes would be combined with provided test, but I see is not the case. Is there a direction to provide test in the codebase so that the intentions are somehow documented and guarded? |
f11h
approved these changes
Apr 26, 2021
|
@M3kH test for the lib are currently under development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the docs of Arrays.copyOfRange. The second range parameter is exclusive, so the -1 needed to be removed, to get the 8 bytes.