Add appendHeader to MockResponse (#306)

* Add the appendHeader function which is part of OutgoingMessage * Add a test for appendHeader * Fix function name --------- Co-authored-by: Eugene Fidelin <eugene.fidelin@gmail.com>
eugef · Sep 9, 2024 · 3a87b42 · 3a87b42
1 parent 845ca93
commit 3a87b42
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/lib/mockResponse.js b/lib/mockResponse.js
@@ -631,6 +631,16 @@ function createResponse(options = {}) {
         return this;
     };
 
+    /**
+     * Function: appendHeader
+     *
+     *   Append a header by name. If a header already exists, the new value is appended to the existing header.
+     */
+    mockResponse.appendHeader = function appendHeader(name, value) {
+        mockResponse.append(name, value);
+        return this;
+    };
+
     /**
      * Function: removeHeader
      *

diff --git a/test/lib/mockResponse.spec.js b/test/lib/mockResponse.spec.js
@@ -84,6 +84,9 @@ describe('mockResponse', () => {
             expect(response).to.have.property('setHeader');
             expect(response.setHeader).to.be.a('function');
 
+            expect(response).to.have.property('appendHeader');
+            expect(response.appendHeader).to.be.a('function');
+
             expect(response).to.have.property('removeHeader');
             expect(response.removeHeader).to.be.a('function');
 
@@ -923,8 +926,8 @@ describe('mockResponse', () => {
         });
     });
 
-    // TODO: fix in 2.0; methods should be inherited from Node OutogingMessage
-    describe('Node OutogingMessage methods', () => {
+    // TODO: fix in 2.0; methods should be inherited from Node OutgoingMessage
+    describe('Node OutgoingMessage methods', () => {
         describe('.setHeader()', () => {
             let response;
 
@@ -950,6 +953,24 @@ describe('mockResponse', () => {
             });
         });
 
+        describe('.appendHeader()', () => {
+            let response;
+
+            beforeEach(() => {
+                response = mockResponse.createResponse();
+            });
+
+            afterEach(() => {
+                response = null;
+            });
+
+            it('should concatenate header values, when called twice with same name', () => {
+                response.appendHeader('name', 'value 1');
+                response.appendHeader('name', 'value 2');
+                expect(response.getHeader('name')).to.eql(['value 1', 'value 2']);
+            });
+        });
+
         describe('.getHeader()', () => {
             let response;