Normalise response headers when storing

eugef · Sep 28, 2018 · da896aa · da896aa
1 parent 1f4cc18
commit da896aa
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/lib/mockResponse.js b/lib/mockResponse.js
@@ -29,6 +29,7 @@ var WritableStream = require('./mockWritableStream');
 var EventEmitter = require('./mockEventEmitter');
 var mime = require('mime');
 var http = require('./node/http');
+var utils = require('./utils');
 
 function createResponse(options) {
 
@@ -138,7 +139,7 @@ function createResponse(options) {
         // should not be overwritten but be merged with the headers
         // passed into `mockResponse.writeHead`.
         if (headers) {
-            Object.assign(mockResponse._headers, headers);
+            Object.assign(mockResponse._headers, utils.convertKeysToLowerCase(headers));
         }
 
     };
@@ -200,7 +201,7 @@ function createResponse(options) {
 
             case 3:
                 _formatData(a);
-                mockResponse._headers = b;
+                mockResponse._headers = utils.convertKeysToLowerCase(b);
                 mockResponse.statusCode = c;
                 console.warn('WARNING: Called send() with deprecated three parameters');
                 break;
@@ -535,9 +536,7 @@ function createResponse(options) {
      *   Returns a particular header by name.
      */
     mockResponse.get = mockResponse.getHeader = function(name) {
-        return mockResponse._headers[name] ||
-            mockResponse._headers[name.toLowerCase()] ||
-            mockResponse._headers[name.toUpperCase()];
+        return mockResponse._headers[name.toLowerCase()];
     };
 
     /**
@@ -547,7 +546,7 @@ function createResponse(options) {
      *   Set a particular header by name.
      */
     mockResponse.setHeader = function(name, value) {
-        mockResponse._headers[name] = value;
+        mockResponse._headers[name.toLowerCase()] = value;
         return value;
     };
 
@@ -557,7 +556,7 @@ function createResponse(options) {
      *   Removes an HTTP header by name.
      */
     mockResponse.removeHeader = function(name) {
-        delete mockResponse._headers[name];
+        delete mockResponse._headers[name.toLowerCase()];
     };
 
     /**