-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for range function #175
Conversation
Very nice, and thanks for the tests. Would it make sense to add some usage examples for this function? |
Yep will do. Shall I also update the change log too, or does that get done when someone releases?
… On 5 Oct 2018, at 22:24, Howard Abrams ***@***.***> wrote:
Very nice, and thanks for the tests. Would it make sense to add some usage examples for this function?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@howardabrams actually thinking about it now, I'm not sure usage examples do make sense? It's just mimicking express's Happy to add a note about support for express methods ( |
A note in the README would be nice, and yeah, if you are going to update the version number then updating the history file would be grand. Thanks for the PR.
… On Oct 7, 2018, at 2:25 AM, Rich Hodgkins ***@***.***> wrote:
@howardabrams <https://github.com/howardabrams> actually thinking about it now, I'm not sure usage examples do make sense? It's just mimicking express's Response.range() function <http://expressjs.com/en/4x/api.html#req.range>, so in reality you don't really need to call the function in tests, it's more for use in express middleware handlers.
Happy to add a note about support for express methods (is, accepts, params) into the README tho?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAejja7szkoTCZyJhw10rl3fgKa04XXJks5uich1gaJpZM4XKaeC>.
|
@howardabrams - done! |
LGTM |
Added in
.range()
function to mock request, including tests.Also tidied up lint warnings and updated version in package-lock.json.