Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulp-eslint errors #219

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

sergioregueira
Copy link
Contributor

The latest pull request #213 added some code that does not satisfy gulp-eslint requirements. I have changed a few things to solve the errors and unblock #217:

  • Use a regular function instead of an arrow one.
  • Wrap if block into brackets.
  • Replace const with var.

@eugef
Copy link
Owner

eugef commented Aug 13, 2020

Thanks for the fix, i think a better long-term solution would be to allow modern ES syntax that is supported by Node 10.

@eugef eugef merged commit 9cbaff7 into eugef:master Aug 13, 2020
@sergioregueira
Copy link
Contributor Author

That would require a transpiler (eg. babel) to keep the library compatible with Node.js 6.

If you agree, open a pull request and I will address it sometime.

@eugef
Copy link
Owner

eugef commented Aug 13, 2020

Node.js org doesn't support versions below 10 https://nodejs.org/en/about/releases/
Neither should do we.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants