New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for req.hostname #224

Merged

eugef merged 1 commit into eugef:master from storm1ng:feature/request-hostname

Sep 28, 2020

Contributor

storm1ng commented Sep 28, 2020 •

edited

Loading

This will add support for req.hostname specified in the expressjs documentation: http://expressjs.com/en/5x/api.html#req.hostname

Note: I didn't implement the X-Forwarded-Host check since we would need to evaluate the trust proxy option: http://expressjs.com/en/5x/api.html#app.set


          feat: add support for req.hostname

0efc56a

Owner

eugef commented Sep 28, 2020

Hi @mjenny, thank you for the PR.

eugef merged commit 74440bc into eugef:master

storm1ng deleted the feature/request-hostname branch

September 28, 2020 10:45

jereaameli mentioned this pull request

req.hostname doesn't reflect real hostname #230

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet