Emit send and end events for json response too

[andriasang]

No description provided.

[marneborn]

I found this same issue today, and am looking at fixing it.

My initial idea was to emit 'json' and then call mockResponse.end(), which emits 'end' and sets _endCalled. However, mockResponse.send() simply emits 'send' and 'end'. And I'd rather be consistent.

Would you rather I change .send to call .end, (and .json to call .send) or make .json act like .send?
The only difference is that _endCalled will be set to true, while right now it's not.

Within express .json (and .jsonp) call .send which then calls .end.
All of the Buffer stuff is done in .send, so the .json method doesn't even really need to be mocked...

[estilles]

@marneborn, I really appreciate your comments.

I've looked into this as well and I agree both .json() and .jsonp() should call .send() which in turn calls .end().

I do, however, disagree that .json()doesn't need to be mocked. In addition to called .send() it also sets the Content-Type header to application/json (if it isn't already set), among other things. So it definitely need to be mocked as well.

The problem ATT is that simply changing .send() to call .end() introduces a breaking change. (See issue #49). I have scheduled fixing this issue in our 2.0 release, the date of which I will be announcing soon.

[estilles]

This issue should be take care of once we roll out release 2.0 (see our Roadmap to Release 2.0, issue #54).