Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving types to peerDependencies and allowing express 5 #309

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Moving types to peerDependencies and allowing express 5 #309

merged 4 commits into from
Oct 4, 2024

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented Oct 3, 2024 •
edited
Loading

Fixes #307
Alternative implementation.

  • Moved @types/express and @types/node (as requested) to peerDependencies
  • Marked those peer dependencies as optional — only needed for those using TypeScript
  • Allowed v5 of @types/express
  • Added testing against latest Node 22

@RobinTail RobinTail mentioned this pull request Oct 3, 2024
Closed
@RobinTail RobinTail marked this pull request as ready for review October 3, 2024 19:15
@RobinTail
Copy link
Contributor Author

@eugef , ready for review

@RobinTail RobinTail mentioned this pull request Oct 3, 2024
Closed
eugef
eugef approved these changes Oct 4, 2024
View reviewed changes
Copy link
Owner

@eugef eugef left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@eugef eugef merged commit fa4ae25 into eugef:master Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugef eugef eugef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Express 5 types released - deduplication problem
2 participants
@RobinTail @eugef