Bringing geosearch component to production #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add geosearch to ignored element tags * feat: integrate working geosearch * chore: push bundle and use new button size parameter * chore: use shConfig to get api key for opencage search endpoint * chore: run linter in map component * chore: push new bundle * chore: add geosearch to list * chore: remove any temp bundles and references to them * chore: register geosearch component by importing it * feat: added geosearch brand specific option; added opencage secrets for opencage and updated deployments configurations for different instances * chore: fixing linter error * fix: moving key definition to map component, linter breaks if it is in the appconfig * chore: updated geopackage; solved wrong variable defintion for key --------- Co-authored-by: santilland <daniel.santillan@eox.at>
lubojr
approved these changes
Jun 26, 2024
|
Good from my side. Should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agreed with Anca and Patrick in weekly/bi-weekly
Also incorporates some data updates