fix: Dealer search and feedback stuff #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukashaertel
commented
Sep 14, 2024
lukashaertel
commented
- Tab label added to control how tab navigator stuff is displayed.
- Viewers initial zoom changed, fixed share debounce.
- Fuse integration increase limit.
- Dealer and event share debounced.
- Dealer and event router new tab label used.
- Profile reload method turned into async callback.
- Fixed search issue where an old property name was used.
lukashaertel
force-pushed
the
fix/third-feedback-and-dealer-fixes
branch
3 times, most recently
from
4e4b234
to
8a9dbe7
Compare
* Platform share icon, iOS usual style not matching up with Android/MCI, added to all share locations, added definition in icon. * Header buttons debounced. * Viewer initial zoom fixed, depadded to match floater spec. * useDebounce hook added. * Tab label added to control how tab navigator stuff is displayed. * Fuse integration increase limit. * Dealer and event router new tab label used. * Fixed search issue where an old property name was used.
lukashaertel
force-pushed
the
fix/third-feedback-and-dealer-fixes
branch
from
8a9dbe7
to
6407112
Compare
* iOS seems to have problems when not called from main thread or something. Removed debouncing.
* Use debounce only on android, apply on share.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.