Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override build directory #118

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Override build directory #118

merged 3 commits into from
Aug 12, 2022

Conversation

reversed-coffee
Copy link
Contributor

At least for me, in my setups I build to a "doc" folder, so this is useful for me. Figured I would open a pull request if it helps anyone else.

Copy link
Owner

@evaera evaera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option should be called --out-dir to mirror the docusarus option. Remember to follow the casing style of the project as well, builddir is not valid, it should be camelCase.

cli/src/argv.ts Outdated
@@ -37,6 +38,12 @@ const argv = yargs(process.argv.slice(2))
"publish",
"publish the built website to your gh-pages branch after building"
)
yargs
.string("builddir")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.string("builddir")
.string("out-dir")

@evaera evaera changed the title Add an 'override' option for building Override build directory Aug 11, 2022
@reversed-coffee
Copy link
Contributor Author

My bad. It was a quick patch and I wasn't thinking it through.

@evaera evaera merged commit af77296 into evaera:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants