-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
full cmake 7/N: library #317
Open
loriab
wants to merge
21
commits into
evaleev:master
Choose a base branch
from
loriab:export
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take 2 try 3 try 4 try 5 try 6 try 7 libint_maybe_unused build src split
take 2 take 3 c++ ho testing take 2 try 3 take 4 take 5 take 6 take 7 take 8 take 8 take 9 fortran try 2 try 3 try 4 try 5 python try 2 try 3 try 4 try 5 try 6 try 7 try 8 try 9 try 10 try 11 try 12 try 13 try 14 try 15 try 16 try 17 helps to spell var correctly try 18 try 19 try 20 try 21 try 22 try 22 try 24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently atop #315 . new base lib in ee93781
BUILD_SHARED_LIBS
andLIBINT2_BUILD_SHARED_AND_STATIC_LIBS
for both.generated/
rather than directly insrc/
so that not removing headers from the dir once generated. I suspect that since all lib builds going through the tarball that__COMPILING_LIBINT
could be removed after editing the export structure.LIBINT2_REQUIRE_CXX_API_COMPILED=OFF
LIBINT2_ENABLE_
prefixes sinceENABLE_PYTHON
is pretty generic and prone to conflicts with FetchContent.full_version
LecrisUT/CMakeExtraUtils#24 (comment)//
comments in ifdefs to/* ... */
since the former were raising warnings with some compilersLIBINT_HAS_MPFR=1