Trigger #20
Merged
Trigger #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoelzl
reviewed
Nov 21, 2016
| {file: 'snowboy.umdl', hotword: 'snowboy'}] | ||
| ``` | ||
|
|
||
| ### Lenguages |
ashishsc
reviewed
Nov 26, 2016
|
|
||
| sonus.trigger = (index, hotword) => { | ||
| if(sonus.started){ | ||
| sonus.emit('hotword', index || "0", hotword || "triggered") |
There was a problem hiding this comment.
Did you actually want string 0?
There was a problem hiding this comment.
It should fallback to zero, but I think in order to best support all scenarios users should be able to pass in an index and a hotword to the trigger function (to accurately simulate the triggering of a specific hotword in case they have hotwords that perform different actions).
Proposed API
Sonus.trigger(sonus)
// Triggers sonus instance with index 0 and hotword "triggered"
Sonus.trigger(sonus, 1, "sonus")
//Triggers sonus instance with index 0 and hotword "sonus"High flexibility and easy to use, or is this crazy 🍌s?
There was a problem hiding this comment.
Yeah - it's actually supposed to be a string... My proposal was wrong.
ashishsc
approved these changes
Dec 5, 2016
ashishsc
reviewed
Dec 18, 2016
| @@ -80,21 +80,31 @@ Sonus.stop(sonus) | |||
| Note that after recognition is stopped it can not be started again without creating an enterly new sonus instance. | |||
|
|
|||
| ### Trigger keyword/hotword manually | |||
| You can manuall trigger a hotword by passing your initialized sonus object into `Sonus.trigger` | |||
| This will throw a `NOT_STARTED` exception if you have not started sonus when this is called. | |||
| You can manuall trigger a hotword by passing your initialized sonus object and an index into `Sonus.trigger` | |||
| sonus.emit('hotword', index, triggerHotword) | ||
| CloudSpeechRecognizer.startStreaming(opts, sonus.mic, csr) | ||
| } catch (e) { | ||
| console.log(e) |
remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ashishsc
Adding sonus hotword trigger and documentation that I wrote on the plane :)
Wasn't sure if this was really the right approach for the trigger, let me know what you think.