Fix Forte [Forte Part] #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcyyork
approved these changes
Mar 26, 2022
fevangelista
requested changes
Mar 26, 2022
| @@ -70,7 +70,6 @@ using namespace pybind11::literals; | |||
| namespace forte { | |||
|
|
|||
| // see the files in src/api for the implementation of the following methods | |||
| void export_ambit(py::module& m); | |||
There was a problem hiding this comment.
It's great to see code removed!
|
Ambit and Psi PRs are in, so tests should pass. |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 59.59% 65.74% +6.14%
==========================================
Files 201 198 -3
Lines 50564 50170 -394
==========================================
+ Hits 30135 32985 +2850
+ Misses 20429 17185 -3244
Continue to review full report at Codecov.
|
fevangelista
approved these changes
Mar 27, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes changes so that
Psican do DIIS on anambit.BlockedTensor, as required by theforteplugin. This PR will not work until this ambit PR and this Psi PR are merged, but passed locally on a slightly outdated version of Forte.ambit.BlockedTensordirectly, with much cleaner code.ambit.BlockedTensorto Python. We now import whateverambitexposes for us.