Doc/improvements for ExternalActiveSpaceMethod
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 66.79% 66.79% -0.01%
==========================================
Files 212 212
Lines 56542 56542
==========================================
- Hits 37766 37765 -1
- Misses 18776 18777 +1 ☔ View full report in Codecov by Sentry. |
RenkeHuang
changed the title
RenkeHuang
changed the title
ExternalActiveSpaceMethod
RenkeHuang
requested review from
fevangelista and
imagoulas
and removed request for
fevangelista
|
@RenkeHuang : most of this looks fine but I was wondering: why did some of the reference files/values change? Is still something left to do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to document the external active space solver interface (PR #217), update the manual and some minor improvements of the JSON interface (issue #325).
Manual
Feature improvements
Checklist