-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WASM #277
Add support for WASM #277
Conversation
55db026
to
04ef2dd
Compare
d13ff49
to
0923a5c
Compare
800cfe8
to
2eab51b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this a shared source set for js
and wasmJs
. The IDE shows some errors, but it seems to be building fine.
fyi, since this only needed for tests, it would be acceptable to skip those tests for the wasm target while it's still experimental |
583ea89
to
90e750b
Compare
769151b
to
9557543
Compare
I don't think it's possible to skip coroutine tests for wasm because atomicfu and coroutines artifacts are clashing. Once the new version of coroutines releases, the commit commenting out coroutines can be reverted and this should be able to be merged. |
kotlin-js-store/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because I kept having to make sure that I wasn't committing it. I think best practice is to track it in git, but I'll remove if you don't want it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best practice is to track it in git
If that's the case, then yeah it's fine to keep, I wasn't sure what was best practice here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, in terms of skipping for wasm my thought would be to move the tests that use coroutines to a source set that excludes wasm, and the wasm target would be the one that doesn't include the coroutine dependency. It shouldn't be bringing in the conflicting dependencies at the same time right? Is there some reason that wouldn't work? |
It should work, but it might be worth waiting for the coroutines release. I'll check in with the kotlinx team to see if they have any kind of timeline. |
Yup, going to try updating to that soon. Are you ok with releasing the RC? |
Rebased onto #333 |
OK should be ready to go. How do you feel about merging with coroutine 1.8-RC? |
It's not something we are distributing with so it should be fine |
Blocked by willowtreeapps/assertk#493