Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental support for Deno #1145

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Experimental support for Deno #1145

merged 2 commits into from
Apr 13, 2021

Conversation

evanw
Copy link
Owner

@evanw evanw commented Apr 13, 2021

This PR introduces experimental support for Deno. You can build the Deno esbuild package using make platform-deno which generates two files, ./deno/mod.js and ./deno/mod.d.ts. When run, mod.js will download and cache the esbuild binary from npm so you'll need network access to npm to use this package. This package requires the --allow-env --allow-read --allow-write --allow-net --allow-run Deno permissions.

The API for the Deno esbuild package is the same as the npm esbuild package with one exception: you need to call stop() when you're done, which kills esbuild's child process. It doesn't look like Deno has an equivalent to node's unref() API so I couldn't figure out how to allow Deno to exit while the esbuild child process is still running. Maybe it's not possible to do that in Deno?

Issue: #936

@evanw evanw merged commit d4a7cd3 into master Apr 13, 2021
@evanw evanw deleted the deno branch April 13, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant