Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version for register? #60

Closed
pspeter3 opened this issue May 15, 2015 · 13 comments
Closed

Publish new version for register? #60

pspeter3 opened this issue May 15, 2015 · 13 comments

Comments

@pspeter3
Copy link
Contributor

No description provided.

@evanw
Copy link
Owner

evanw commented May 16, 2015

I'd like to but the tests aren't passing due to the new changes coming in. I now see four failing tests. @julien-f?

@julien-f
Copy link
Collaborator

Unfortunately I don’t have access to a computer this weekend, if you need me it will have to wait Monday.

I suspect #47 or #58.

@julien-f
Copy link
Collaborator

We should set up CI to avoid that in the future (will probably set up Travis CI on Monday if you agree).

@pspeter3
Copy link
Contributor Author

Pull request #47 is the cause for most of the test failures. Removing it only causes one to fail. I'm investigating more now

@pspeter3
Copy link
Contributor Author

I added a pull request to pass the tests and will follow up with a test for #36

@pspeter3
Copy link
Contributor Author

And now restored the behavior of #47

@pspeter3
Copy link
Contributor Author

Now that the pull request is closed, can we push a new version?

@evanw
Copy link
Owner

evanw commented May 27, 2015

I've also got some manual tests for browser-related stuff. I'm not sure if you've been running those too but it looks like the browserify test is failing due to commit b3fd2b9 by @mprobst.

@mprobst
Copy link
Collaborator

mprobst commented May 27, 2015

@evanw any more details on how it fails? npm test succeeds for me, but opening index.html doesn't. How do you run the test?

@evanw
Copy link
Owner

evanw commented May 28, 2015

Sorry, that isn't obvious. Added instructions to the readme: https://github.com/evanw/node-source-map-support/blob/master/README.md#tests. They have to run over the HTTP protocol because the file protocol is hopelessly broken.

@evanw
Copy link
Owner

evanw commented May 29, 2015

Just published as version 0.3.0.

@evanw evanw closed this as completed May 29, 2015
@pspeter3
Copy link
Contributor Author

The new version seems to no longer work in my code base for reading file maps

@evanw
Copy link
Owner

evanw commented May 30, 2015

@pspeter3 I just merged your pull request and published 0.3.1. Does that fix your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants