Fixed sourcemap url detection from code. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julien-f quick review before merge? |
|
I do not think the URL may be surrounded by quotes nor prefixed by spaces. Appart from that I think it's fair to assume that an URL should not contain any quote because the source map spec say:
|
|
I agree... |
|
I've included the surrounded quotes match, just in case the specs or any custom implementation change... |
|
I think, for now, it should be enough to just change Would that be enough to fix your problem? |
|
Yep, I change the code and squash commits... |
marcominetti
pushed a commit
that referenced
this pull request
May 15, 2015
Fixed sourcemap url detection.
This was referenced May 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brutally fixes #57 ... Assuming there is never ' or " within the uri...