Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove --debug flag for browserify. #66

Closed
wants to merge 1 commit into from

Commits on May 28, 2015

  1. fix: remove --debug flag for browserify.

    According to the spec (https://goo.gl/UQJKOW) the source map comment should be
    at the very end of the file. Browser's adhere to that, i.e. use the last source
    map in the file.
    
    Browserify's --debug adds a source map at the bottom of the compiled file, but
    currently fails to combine that with the source map referenced in script.js.
    This is a bug in Browserify, see issue
    browserify/browserify#772.
    
    Our test case thus only worked by accident, for the user in the browser only
    "script.js" shows up, not "script.coffee" as it should.
    
    So for the time being, we should just remove the --debug flag from the build and
    re-enable once browserify fixes that issue.
    mprobst committed May 28, 2015
    Configuration menu
    Copy the full SHA
    85464a3 View commit details
    Browse the repository at this point in the history