Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to change styles of input #4

Closed
wants to merge 8 commits into from

Conversation

wtfil
Copy link

@wtfil wtfil commented Mar 18, 2016

Hi!
First of all, thank you for material input.
I found few things which could be better:

  • style property may be useful for overwriting such things as color and fontSize
  • new props should update state of component

@wtfil wtfil force-pushed the master branch 2 times, most recently from 83e7951 to 9a6a4bc Compare March 30, 2016 12:56
new props will reset input value from store
@philipshurpik
Copy link

Hi!

I have added support of properties: wrapperStyle, inputStyle, labelStyle to be able to change styles of all components in field.
Also added possibility to change input and label fontSize from corresponding styles.

And reformatted code - to use 2 spaces in all files :)
If you like another formatting - please note - I will change )
But now it's really more comfortable to look at and contribute in project )

@evblurbs
Copy link
Owner

I apologize for the delayed response! I like the additions here!

Since I've done a poor job of updating it (I should be watching this repo more regularly now that I'm using it myself more), there are a number of conflicts with this pull request. Some of them have already been addressed:

I like the idea of being able to customize the styles. My first pass was to just follow the Material Design guidelines strictly. I'll add that methods and update this thread accordingly.

@evblurbs
Copy link
Owner

I've added the props inputStyle, wrapperStyle, and labelStyle. Thanks @wtfil and @philipshurpik for your help!

I've also added the props textColor, textFocusColor, and textBlurColor to provide more control of the TextInput color.

I'll look into the other updates made here later.

@wtfil wtfil closed this Aug 2, 2017
@wtfil
Copy link
Author

wtfil commented Aug 2, 2017

Closing since this is not relevant any more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants