Skip to content

Commit

Permalink
chore: npm dependencies upgrade, node 18 > 22 (#15748)
Browse files Browse the repository at this point in the history
  • Loading branch information
naltatis authored Aug 28, 2024
1 parent f53d4de commit 0d7cdbe
Show file tree
Hide file tree
Showing 5 changed files with 1,234 additions and 465 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: "18"
node-version: "22"
cache: "npm"

- run: mkdir dist && touch dist/empty
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: "18"
node-version: "22"
cache: "npm"

- name: Install
Expand Down Expand Up @@ -199,7 +199,7 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: "18"
node-version: "22"
cache: "npm"

- name: Build UI
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#### Development environment

Developing evcc requires [Go][1] 1.23 and [Node][2] 18. We recommend VSCode with the [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go), [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) and [Vetur](https://marketplace.visualstudio.com/items?itemName=octref.vetur) extensions.
Developing evcc requires [Go][1] 1.23 and [Node][2] 22. We recommend VSCode with the [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go), [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) and [Vetur](https://marketplace.visualstudio.com/items?itemName=octref.vetur) extensions.

We use linters (golangci-lint, Prettier) to keep a coherent source code formatting. It's recommended to use the format-on-save feature of your editor. You can manually reformat your code by running:

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# STEP 1 build ui
FROM --platform=$BUILDPLATFORM node:18-alpine as node
FROM --platform=$BUILDPLATFORM node:22-alpine as node

RUN apk update && apk add --no-cache make

Expand Down
Loading

0 comments on commit 0d7cdbe

Please sign in to comment.