Update EEBUS to use version 0.6 of EEBUS libs #13998

DerAndereAndi · 2024-05-20T19:32:09Z

Update to eebus-go v0.6.0, spine-go v0.6.0 and ship-go v0.5.1
Add better support for VW ISO VAS capable chargers and EVs, to enable them to go to sleep

DerAndereAndi · 2024-05-20T19:34:09Z

This can also be used as a foundation to implement communication with a control box. But I recommend moving the eebus server then from charger to the server package.

I tested this with a software emulation of a wallbox so far. Will test with multiple wallboxes during the next week.

The updated version should also have everything needed to provide an interactive pairing UI. E.g. list all visible remote EEBUS devices, initiate a pairing request, but also react to incoming pairing requests.

andig · 2024-05-21T11:17:22Z

@DerAndereAndi ersetzt das dann #12407 oder ist das hier ein Zwischenschritt?

I tested this with a software emulation of a wallbox so far.

Könntest Du die teilen oder finde ich die in https://github.com/enbility/cemd? Vielen Dank!

The updated version should also have everything needed to provide an interactive pairing UI. E.g. list all visible remote EEBUS devices, initiate a pairing request, but also react to incoming pairing requests.

Das wäre ein Thema dem wir uns widmen wollen wenn das Config UI released ist.

DerAndereAndi · 2024-05-21T14:49:44Z

@DerAndereAndi ersetzt das dann #12407 oder ist das hier ein Zwischenschritt?

Ja, das ersetzt deinen PR.

Könntest Du die teilen oder finde ich die in https://github.com/enbility/cemd? Vielen Dank!

Nein, das geht leider nicht.

Das wäre ein Thema dem wir uns widmen wollen wenn das Config UI released ist.

👍

andig · 2024-05-24T06:45:02Z

Nein, das geht leider nicht.

Schade. Mir fehlt mangels Gerät jede Möglichkeit, hier etwas beizutragen ausser "trocken" coding.

Es wäre Klasse den PR fertig zu bekommen- aktuell ist aufgrund der geänderten Struktur keine (einfache) Aktualisierung der Dependencies mehr möglich.

charger/eebus.go

andig · 2024-06-07T06:50:01Z

Hi Andi, kann ich irgendwie helfen den PR zu finalisieren? Aufgrund der 0.x Versionen hängen wir sonst im Dependency Upgrade fest:

go: downloading golang.org/x/crypto/x509roots/fallback v0.0.0-20240604170348-d4e7c9cb6cb8
go: downloading golang.org/x/oauth2 v0.21.0
go: downloading github.com/itchyny/gojq v0.12.16
go: downloading github.com/go-playground/validator/v10 v10.21.0
go: downloading github.com/prometheus/common v0.54.0
go: downloading github.com/itchyny/timefmt-go v0.1.6
go: downloading modernc.org/sqlite v1.30.0
go: downloading github.com/prometheus/procfs v0.15.1
go: downloading google.golang.org/genproto v0.0.0-20240604185151-ef581f913117
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117
go: downloading github.com/aws/aws-sdk-go v1.53.18
go: downloading github.com/insomniacslk/xjson v0.0.0-20240605162811-87a2577578b2
go: downloading modernc.org/libc v1.52.1
go: github.com/evcc-io/evcc imports
	github.com/evcc-io/evcc/cmd imports
	github.com/evcc-io/evcc/charger imports
	github.com/enbility/cemd/emobility: cannot find module providing package github.com/enbility/cemd/emobility
go: github.com/evcc-io/evcc imports
	github.com/evcc-io/evcc/cmd imports
	github.com/evcc-io/evcc/charger/eebus imports
	github.com/enbility/eebus-go/spine/model: cannot find module providing package github.com/enbility/eebus-go/spine/model
go: downloading modernc.org/ccgo/v4 v4.17.10

DerAndereAndi · 2024-06-07T07:48:43Z

Ich kann erst nächste Woche wenn ich mein Auto wieder habe weiter machen.

Alternative für upgrades: du änderst die bisherige Nutzung von Versionsnummer auf den entsprechenden Commit.

andig · 2024-06-09T12:12:26Z

Komischerweise klappt das beim cemd nicht:

go get -v github.com/enbility/cemd@2839324 -> github.com/enbility/cemd v0.2.2

Bei eebus-go gehts:

github.com/enbility/eebus-go v0.2.1-0.20230521185917-1bae87b0ec27

Sieht aus, als würde das Go Tooling das nicht zulassen.

DerAndereAndi · 2024-06-09T12:21:24Z

go.mod direkt editieren mit:

github.com/enbility/eebus-go v0.0.0-20230521185917-1bae87b0ec27
github.com/enbility/cemd v0.0.0-20230426193025-28393246b3d0

sollte gehen. Bei CEMD evtl. das Datum auch auf 20230426183025 setzen.

andig · 2024-06-09T12:27:59Z

Tut auch nicht:

go get -u
go: downloading github.com/enbility/cemd v0.0.0-20230426183025-28393246b3d0
go: github.com/evcc-io/evcc imports
	github.com/evcc-io/evcc/cmd imports
	github.com/evcc-io/evcc/charger imports
	github.com/enbility/cemd/emobility: cannot find module providing package github.com/enbility/cemd/emobility
go: github.com/evcc-io/evcc imports
	github.com/evcc-io/evcc/cmd imports
	github.com/evcc-io/evcc/charger/eebus imports
	github.com/enbility/eebus-go/spine/model: cannot find module providing package github.com/enbility/eebus-go/spine/model

Ich warte einfach ;)

andig · 2024-06-23T15:34:35Z

Fixed by replacing the versions in 27d67d0

DerAndereAndi · 2024-06-29T14:42:17Z

Tested with two EEBUS compatible chargers and works great. It even seems to improve the crashing issues of the Elli Charger Connect and Pro wallboxes to some extend for me.

This updates the eebus charger implementation to use the latest version 0.5 implementations of cemd, eebus, spine and ship

Only use OSCEV if the a wallbox with ISO15118-2 VW VAS is connected, and the EV is using this. This also enables full charging control and putting the EV to sleep. All other current implementations of the usecase are basically wrong and are no different than using OPEV.

- Updated to eebus-go v0.6.0, spine-go v0.6.0 and ship-go v0.5.1 - Various updates and fixes

andig · 2024-06-29T15:36:43Z

Ich hatte die use cases in #12407 noch (für meinen Geschmack) minimal eleganter erzeugt:

	// create use cases
	service := c.cem.Service
	c.uc = &Usecases{
		EvseCC: ucevsecc.NewUCEVSECC(service, c.evseHandler),
		EvCC:   ucevcc.NewUCEVCC(service, c.evHandler),
		EvCem:  ucevcem.NewUCEVCEM(service, c.evHandler),
		OpEV:   ucopev.NewUCOPEV(service, c.evHandler),
		EvSoc:  ucevsoc.NewUCEVSOC(service, c.evHandler),
	}

	// register use cases
	for _, uc := range []cemdapi.UseCaseInterface{
		c.uc.EvseCC,
		c.uc.EvCC, c.uc.EvCem, c.uc.OpEV, c.uc.EvSoc,
	} {
		c.cem.AddUseCase(uc)
	}

andig · 2024-06-29T15:49:44Z

Klasse- hab noch ein paar Kleinigkeiten geändert und die Cert-Funktionen raus gezogen.

andig · 2024-06-29T15:52:16Z

Meinst Du das kann ins Nightly oder lieber bis nach Release warten?

DerAndereAndi · 2024-06-29T15:52:46Z

Wenn du kurzfristig ein Release planst, lieber danach

andig · 2024-06-30T12:24:00Z

Klasse- dann rein damit. Es steht grad nix Kritisches an.

andig · 2024-08-05T17:25:33Z

charger/eebus.go

 	if err != nil {
-		// there are no overload protection limits available, e.g. because the data was not received yet
+		// there are limits available, e.g. because the data was not received yet


@DerAndereAndi der Kommentar sollte "no limits" heißen? Oder ist die Bedingung falsch?

Den Kommentar gibt es im aktuellen Code nicht und die Stelle greift nur bei VAS => Taycan. Das läuft sauber.

Arg, falsche Stelle. Den gibts immer noch:

limits, err := c.uc.OpEV.LoadControlLimits(evEntity) if err != nil { // there are limits available, e.g. because the data was not received yet c.log.DEBUG.Println("!! OpEV.LoadControlLimits error", err) return true, nil }

An der Stelle hier falsch?

Glaube ich kaum, denn Limits sind im Ablauf ja da und gesetzt.

Mir gehts nur um den Kommentar- der müsste heissen "no limits"? Dann würde ich das lokal korrigieren.

DerAndereAndi marked this pull request as draft May 20, 2024 19:32

andig added the enhancement New feature or request label May 21, 2024

andig mentioned this pull request May 21, 2024

EEbus: upgrade stack to v2 #12407

Closed

andig reviewed May 24, 2024

View reviewed changes

charger/eebus.go Show resolved Hide resolved

andig mentioned this pull request Jun 1, 2024

MPL license enbility/spine-go#22

Closed

DerAndereAndi mentioned this pull request Jun 7, 2024

Add documentation enbility/eebus-go#18

Open

DerAndereAndi force-pushed the feature/eebus05 branch from 1f2a4a2 to 13d9155 Compare June 29, 2024 14:38

DerAndereAndi changed the title ~~Update EEBUS to use version 0.5 of EEBUS libs~~ Update EEBUS to use version 0.6 of EEBUS libs Jun 29, 2024

DerAndereAndi marked this pull request as ready for review June 29, 2024 14:45

DerAndereAndi added 4 commits June 29, 2024 16:46

Update EEBUS to use version 0.5 of EEBUS libs

171445f

This updates the eebus charger implementation to use the latest version 0.5 implementations of cemd, eebus, spine and ship

Minor fix

802c99c

Update EEBUS libraries and add fixes

c0c1461

- Updated to eebus-go v0.6.0, spine-go v0.6.0 and ship-go v0.5.1 - Various updates and fixes

DerAndereAndi force-pushed the feature/eebus05 branch from 13d9155 to c0c1461 Compare June 29, 2024 14:46

Merge branch 'master' into feature/eebus05

3cafd68

DerAndereAndi and others added 2 commits June 29, 2024 17:44

Improve code style per suggestion

e7ba12c

Minor optimisation

6765fd3

Re-add IP for compatibility

7a158e9

andig merged commit b2f6816 into evcc-io:master Jun 30, 2024
6 checks passed

andig mentioned this pull request Jul 2, 2024

EEbus: remove ip #14662

Merged

andig mentioned this pull request Aug 5, 2024

EEbus (Bender): Laden startet und stoppt immer wieder im PV Modus ohne PV Leistung #15246

Closed

andig reviewed Aug 5, 2024

View reviewed changes

DerAndereAndi deleted the feature/eebus05 branch August 5, 2024 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EEBUS to use version 0.6 of EEBUS libs #13998

Update EEBUS to use version 0.6 of EEBUS libs #13998

DerAndereAndi commented May 20, 2024 •

edited

Loading

DerAndereAndi commented May 20, 2024 •

edited

Loading

andig commented May 21, 2024 •

edited

Loading

DerAndereAndi commented May 21, 2024

andig commented May 24, 2024

andig commented Jun 7, 2024

DerAndereAndi commented Jun 7, 2024

andig commented Jun 9, 2024 •

edited

Loading

DerAndereAndi commented Jun 9, 2024

andig commented Jun 9, 2024

andig commented Jun 23, 2024

DerAndereAndi commented Jun 29, 2024

andig commented Jun 29, 2024

andig commented Jun 29, 2024

andig commented Jun 29, 2024

DerAndereAndi commented Jun 29, 2024

andig commented Jun 30, 2024

andig Aug 5, 2024

DerAndereAndi Aug 5, 2024

andig Aug 5, 2024

andig Aug 5, 2024

DerAndereAndi Aug 5, 2024

andig Aug 5, 2024

Update EEBUS to use version 0.6 of EEBUS libs #13998

Update EEBUS to use version 0.6 of EEBUS libs #13998

Conversation

DerAndereAndi commented May 20, 2024 • edited Loading

DerAndereAndi commented May 20, 2024 • edited Loading

andig commented May 21, 2024 • edited Loading

DerAndereAndi commented May 21, 2024

andig commented May 24, 2024

andig commented Jun 7, 2024

DerAndereAndi commented Jun 7, 2024

andig commented Jun 9, 2024 • edited Loading

DerAndereAndi commented Jun 9, 2024

andig commented Jun 9, 2024

andig commented Jun 23, 2024

DerAndereAndi commented Jun 29, 2024

andig commented Jun 29, 2024

andig commented Jun 29, 2024

andig commented Jun 29, 2024

DerAndereAndi commented Jun 29, 2024

andig commented Jun 30, 2024

andig Aug 5, 2024

Choose a reason for hiding this comment

DerAndereAndi Aug 5, 2024

Choose a reason for hiding this comment

andig Aug 5, 2024

Choose a reason for hiding this comment

andig Aug 5, 2024

Choose a reason for hiding this comment

DerAndereAndi Aug 5, 2024

Choose a reason for hiding this comment

andig Aug 5, 2024

Choose a reason for hiding this comment

DerAndereAndi commented May 20, 2024 •

edited

Loading

DerAndereAndi commented May 20, 2024 •

edited

Loading

andig commented May 21, 2024 •

edited

Loading

andig commented Jun 9, 2024 •

edited

Loading