Easee: add command response logging to improve debugging #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @GrimmiMeloni |
andig
reviewed
Apr 22, 2023
andig
reviewed
Apr 22, 2023
naltatis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unreliable current restore after resume charging (pv surplus, phase switch).We read and store the CommandResponse reference returned by the resume POST request and wait for confirmation of this command via SignalR.
Fixes issue described here: #7366Update: Reduced the change to just logging. Hopefully this helps to better understand what's going on in the Easee system and spot timing issues and race conditions (see also #7585 and #7366).