Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/easee prevent parallel start stop #8433

Merged

Conversation

GrimmiMeloni
Copy link
Collaborator

@GrimmiMeloni GrimmiMeloni commented Jun 12, 2023

Fix #8398

Followup to #8307, removed retry logic for empty responses, as according to new found understanding of the API these will always yield the same result.

Marking as draft for now. Will have to wait till sunrise tomorrow to see if this works.

GrimmiMeloni and others added 30 commits June 4, 2023 17:21
This reverts commit 64cb372.
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
Co-authored-by: andig <cpuidle@gmx.de>
@andig andig added the bug Something isn't working label Jun 13, 2023
charger/easee.go Outdated Show resolved Hide resolved
@GrimmiMeloni GrimmiMeloni marked this pull request as ready for review June 13, 2023 13:24
@GrimmiMeloni
Copy link
Collaborator Author

This is ready for review / merge again.

I have tested locally, including reset of the WB to replicate the scenario that @kai-morich had.
Enabling was still not required for my box, but it returned the empty reply and we got past that.
Resume Charge + Settings for Dynamic Charger current still looks solid. Car started charging as expected.

@kai-morich
Copy link

ich teste gerade deinen PR branch. Warte noch auf Sonne für 1p3p-Umschaltung, sieht aber soweit gut aus. Lädt korrekt, keine Warnings, keine unnötigen Requests.

folgende Sequenz zeigt schön das Verhalten mit leerer response.
Das blaue Licht wird mit smartCharging angeschaltet mit async response. Aus unerfindlichen Gründen liefert ProductUpdate false dadurch wird der Status in evcc zurückgesetzt und smartCharging nochmal abgeschickt, diesmal mit leerer response, weil Status easee intern wohl inzwischen richtig. Damit ist smartCharging erledigt und wird nicht mehr wiederholt.

[easee ] TRACE 2023/06/14 15:19:11 POST https://api.easee.com/api/chargers/EHCUMYZ7/settings
[easee ] TRACE 2023/06/14 15:19:11 {"smartCharging":true}
--
[{"device":"EHCUMYZ7","commandId":11,"ticks":638223455517978810}]
[easee ] TRACE 2023/06/14 15:19:12 CommandResponse EHCUMYZ7: {SerialNumber:EHCUMYZ7 ID:11 Timestamp:2023-06-14 13:19:11.797881 +0000 UTC DeliveredAt:2023-06-14 13:19:10.335 +0000 UTC WasAccepted:true ResultCode:0 Comment: Ticks:638223455517978810}
[lp-1  ] DEBUG 2023/06/14 15:19:12 charger status: B
[lp-1  ] DEBUG 2023/06/14 15:19:12 available power 1567W < 4140W min 3p threshold
[lp-1  ] DEBUG 2023/06/14 15:19:12 start phase scale1p timer
[lp-1  ] DEBUG 2023/06/14 15:19:12 phase scale1p in 3m0s
[lp-1  ] DEBUG 2023/06/14 15:19:12 pv charge current: 2.27A = 0A + 2.27A (-1567W @ 3p)
[site  ] DEBUG 2023/06/14 15:19:12 ----
[lp-1  ] DEBUG 2023/06/14 15:19:12 charge power: 0W
[site  ] DEBUG 2023/06/14 15:19:12 static grid tariff
[easee ] TRACE 2023/06/14 15:19:13 ProductUpdate EHCUMYZ7: LEDMODE 21
[easee ] TRACE 2023/06/14 15:19:13 ProductUpdate EHCUMYZ7: SMART_CHARGING false
[easee ] TRACE 2023/06/14 15:19:13 ProductUpdate EHCUMYZ7: SMART_CHARGING false
[site  ] DEBUG 2023/06/14 15:19:27 pv power: 1946W
[site  ] DEBUG 2023/06/14 15:19:27 grid power: -1578W
[site  ] DEBUG 2023/06/14 15:19:27 site power: -1578W
[lp-1  ] DEBUG 2023/06/14 15:19:27 charge currents: [0.338 0.012 0.009]A
[lp-1  ] DEBUG 2023/06/14 15:19:27 charge meter total import: 1423.285kWh
[easee ] TRACE 2023/06/14 15:19:27 POST https://api.easee.com/api/chargers/EHCUMYZ7/settings
[easee ] TRACE 2023/06/14 15:19:27 {"smartCharging":true}
--
[]

charger/easee.go Outdated Show resolved Hide resolved
@andig
Copy link
Member

andig commented Jun 14, 2023

LGTM!

@andig andig merged commit 1ec690c into evcc-io:master Jun 14, 2023
@GrimmiMeloni GrimmiMeloni deleted the issue/easee-prevent-parallel-start-stop branch June 19, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easee: api commands ignored
3 participants