Add new feature --ignore #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* --ignore is used to ignore all CVE ids found a provided file.
evdenis
requested changes
Aug 20, 2022
| @@ -70,6 +71,8 @@ def main(args=sys.argv[1:]): | |||
| help="don't use files hint from cocci rules") | |||
| parser.add_argument('--metadata', metavar='PATH', | |||
| help="Path to non-standard location of kernel_cves.json.gz") | |||
| parser.add_argument('--ignore', nargs='?', const='-', | |||
| help="Ignore CVEs from file (seperated by new line)") | |||
| @@ -170,6 +173,17 @@ def main(args=sys.argv[1:]): | |||
| print('Unknown CVE:', cve, file=sys.stderr) | |||
| sys.exit(1) | |||
|
|
|||
| if args['ignore']: | |||
| with open(args['ignore'], 'r', encoding='utf-8') as ignore_file: | |||
| cve_id = re.compile(r'^CVE-\d{4}-\d{4,7}') | |||
There was a problem hiding this comment.
I think you can use already compiled cve_id pattern. This line seems excessive.
| @@ -28,6 +28,7 @@ def check_config(config): | |||
| 'report', | |||
| 'all_files', | |||
| 'metadata', | |||
| 'ignore', | |||
There was a problem hiding this comment.
I think we can use already existing --exclude for this. Just check is it a CVE-id or file with CVE-ids.
|
Thanks! I merged the branch. I'll add some small changes in follow up commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature would be really usefull for automations or scripts using cvehound due to the fact that passing a file is easier than concatenate a string