fix: fix warning for setup.cfg in humble #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Humble環境でビルドする時に出力される、PythonライブラリのWarningを解消します。
colcon内部で呼び出されるsetuptoolsのバージョンアップにより、setup.cfgで使われる設定値の名前のセパレータは"-"ではなく"_"を使うべきとのWarningが追加されました。setup.cfgの該当箇所を修正し、Warningが出力されないようにします。
Related links
Tests performed
colconのビルドが正常に完了し、以下のWarningが出力されないこと。
以下のWarningについては、ament_cmake, colconのIssue(ament_cmake issue:382, colcon issue:454)にて結論が出ていないことから、修正を見送っております。
/usr/lib/python3/dist-packages/setuptools/command/easy_install.py:158: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools. warnings.warn( /usr/lib/python3/dist-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools. warnings.warn(
修正により、install/audio_driverの配下にコピーされるファイルの違いがないことも確認済です。
修正前後でどちらも以下の出力となります。
install/audio_driverに対するtreeコマンドのログ。
Notes for reviewers
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.