fix(listener): return if there is no arguments (#6)

README.md

@@ -17,24 +17,23 @@
 [![prettier][prettier-badge]][prettier]
 [![license][license-badge]][license]
 
-## Installation
-
-https://github.com/apps/polls
-
 ## Usage
 
+1. Configure the GitHub App: [github.com/apps/polls](https://github.com/apps/polls)
+2. Add command to issue:
+
 ```md
 /polls Option1 'Option 2' "Option 3"
 
 # Automatically replace with the following markdown =>
-[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXY635WEJEYKJV0BZ9WFPJVS/Option1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXY635WEJEYKJV0BZ9WFPJVS/Option1/vote)
-[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXY635WEJEYKJV0BZ9WFPJVS/Opntio%202)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXY635WEJEYKJV0BZ9WFPJVS/Opntio%202/vote)
-[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXY635WEJEYKJV0BZ9WFPJVS/Option%203)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXY635WEJEYKJV0BZ9WFPJVS/Option%203/vote)
+[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXZMATAZ5BXF8RVRAMRSSANA/Option1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXZMATAZ5BXF8RVRAMRSSANA/Option1/vote)
+[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXZMATAZ5BXF8RVRAMRSSANA/Option%202)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXZMATAZ5BXF8RVRAMRSSANA/Option%202/vote)
+[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXZMATAZ5BXF8RVRAMRSSANA/Option%203)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BXZMATAZ5BXF8RVRAMRSSANA/Option%203/vote)
 ```
 
-| **Screenshot** | **Demo** |
+| **Screenshot** | [![](./docs/screenshot.png)](https://github.com/evenchange4/gh-polls-bot/issues/2)  |
 | -------------- | -------- |
-| ![](./docs/screenshot.png) | ![](./docs/demo.gif) |
+| **Demo** | ![](./docs/demo.gif) |
 
 ## Developer Guide
 
@@ -43,6 +42,8 @@ https://github.com/apps/polls
 - Create a `.env` file from `.env.example`.
 - Download the `private-key.pem` from GitHub and move it to your project’s directory.
 
+> Note: Please follow the [Developing an App](https://probot.github.io/docs/development/) section of Probot documents.
+
 ### Requirements
 
 -   node >= 9.0.0
@@ -69,7 +70,7 @@ $ yarn run flow
 
 Any git commits push to master branch.
 
-> PRIVATE_KEY pem workaround: [first-timers-bot #89](https://github.com/hoodiehq/first-timers-bot/pull/89)
+> Note: PRIVATE_KEY pem workaround: [first-timers-bot #89](https://github.com/hoodiehq/first-timers-bot/pull/89)
 
 ### Technology Stacks
 

package.json

@@ -52,6 +52,18 @@
   "engines": {
     "node": ">=9.0.0"
   },
+  "jest": {
+    "testEnvironment": "node",
+    "collectCoverageFrom": [
+      "src/**/*.{js,jsx}",
+      "!src/**/*.test.{js,jsx}"
+    ],
+    "testPathIgnorePatterns": [
+      "<rootDir>/node_modules/",
+      "<rootDir>/coverage/",
+      "<rootDir>/flow-typed/"
+    ]
+  },
   "prettier": {
     "trailingComma": "all",
     "singleQuote": true

src/__tests__/listener.test.js

@@ -19,7 +19,6 @@ it('should handle addPollListener', async () => {
       },
     },
     github: mockGitHubAPI,
-    // GitHub API
     issue: data => data,
   };
   await addPollListener(mockContext);
@@ -35,3 +34,54 @@ it('should handle addPollListener', async () => {
 [![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3/vote)`,
   });
 });
+
+it('should not addLabels if there is one', async () => {
+  const mockGitHubAPI = {
+    issues: {
+      addLabels: jest.fn(),
+      edit: jest.fn(),
+    },
+  };
+  const mockContext = {
+    payload: {
+      issue: {
+        body: 'H1H3\n/polls 1 2 3',
+        labels: ['Polls'],
+      },
+    },
+    github: mockGitHubAPI,
+    issue: data => data,
+  };
+  await addPollListener(mockContext);
+
+  expect(mockGitHubAPI.issues.addLabels).not.toHaveBeenCalled();
+  expect(mockGitHubAPI.issues.edit).toHaveBeenCalledWith({
+    body: `H1H3
+[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/1)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/1/vote)
+[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/2)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/2/vote)
+[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/ID/3/vote)`,
+  });
+});
+
+it('should handle commands without any arguments', async () => {
+  const mockGitHubAPI = {
+    issues: {
+      addLabels: jest.fn(),
+      edit: jest.fn(),
+    },
+  };
+  const mockContext = {
+    payload: {
+      issue: {
+        body: 'H1H3\n/polls',
+        labels: ['Polls'],
+      },
+    },
+    github: mockGitHubAPI,
+    issue: data => data,
+  };
+  await addPollListener(mockContext);
+
+  expect(mockGitHubAPI.issues.addLabels).not.toHaveBeenCalled();
+  expect(mockGitHubAPI.issues.edit).not.toHaveBeenCalled();
+});

src/listener.js

@@ -8,6 +8,9 @@ const { LABEL } = require('./utils/config');
 const addPollListener = async (context /* : any */) => {
   const { body, labels } = context.payload.issue;
   const [command, argument] = getCommand(body);
+
+  if (!argument) return;
+
   const options = split(argument);
 
   try {

src/utils/__tests__/__snapshots__/getCommand.test.js.snap

@@ -7,6 +7,13 @@ Array [
 ]
 `;
 
+exports[`should return command without argument 1`] = `
+Array [
+  "/polls",
+  undefined,
+]
+`;
+
 exports[`should return only one command 1`] = `
 Array [
   "/polls 4 5 6",

src/utils/__tests__/getCommand.test.js

@@ -32,3 +32,12 @@ it('should return the first matched command', () => {
   `;
   expect(getCommand(body)).toMatchSnapshot();
 });
+
+it('should return command without argument', () => {
+  const body = `
+# H1
+## H2
+/polls
+  `;
+  expect(getCommand(body)).toMatchSnapshot();
+});