-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not possible to use multi-host connection string for PostgreSQL #152
Comments
I had a quick look at the code. I think your proposed solution is a good one. |
@klausvahter any progress on the PR? |
Recently had a go-live, so we've been pretty busy, but I'll try to provide the PR today. (I merged my personal and work accounts in GH, so this is my new account, with all the previous orgs and emails connected to this). |
rrrship
added a commit
to rrrship/eventuate-cdc
that referenced
this issue
Oct 11, 2023
cer
added a commit
that referenced
this issue
Nov 1, 2023
#152 add support for multi-host connection string for Postgres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using Amazon Aurora (PostgreSQL implementation), then it's suggested by AWS to configure the connection URL with a list of hosts. Unfortunately Eventuate CDC does not support that and the application is not able to boot up.
The issue is in DbLogClient.java constructor where JdbcUrlParser is used to parse the host and port values. The parser does not support fail-over syntax of JDBC driver. I saw that these values are actually only used by MySqlBinaryLogClient.java and PostgresWalClient actually uses the full URL, so in our temporary fork I just moved the port and host parsing to MySqlBinaryLogClient.
I'm ready to provide a PR to this, but wondering what would be the right approach. Is there some reason why the parsing needs to be in the DbLogClient class?
The text was updated successfully, but these errors were encountered: