-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#188 fix auto-configuration loading in Spring Boot 3 #189
Conversation
} | ||
|
||
dependencies { | ||
compile "com.jayway.restassured:rest-assured:2.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't download this anymore
@@ -57,7 +57,7 @@ include 'eventuate-tram-micronaut-commands' | |||
include 'eventuate-tram-test-util' | |||
include "eventuate-tram-testing-support" | |||
include "eventuate-tram-spring-testing-support-cloud-contract" | |||
include "eventuate-tram-aggregate-domain-events" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this module is not used anywhere
all tests are passing except build-and-test-all-postgres-wal-rabbitmq.sh. same thing happens even on master branch the CDC failed to start.
|
What type of machine are you using for development? ARM/M1 by any chance? |
@kwonglau Great that you have made these changes. I was going to ask you to add a simple But then it wasn't obvious what it should actually do. Perhaps run |
e9d342b
to
d522bd6
Compare
@cer I'm using an intel chip mac. I just added a test per your suggestion and the tests are passing. :D |
I tried the latest rabbitmq image in the docker compose file
and here is full stack trace
I checked the cdc source code, but I can't tell what is missing
|
hey @kwonglau do you have a plan to merge this PR or are you waiting further instructions regarding the upgrade process? we are upgrading our spring version but would need to have the updated eventuate |
Sorry for the delay in merging those PRs. |
there is nothing pending on my end. @romaolucas thanks @cer |
Hi @cer, do you have an idea when a new version will be released with this fix? |
@rafaela-escobar @romaolucas sorry for the delay Today, I fixed what I believe are the remaining issues. Specifically, https://github.com/eventuate-tram/eventuate-tram-sagas-examples-customers-and-orders/tree/wip-spring-boot-3 is working except for eventuate-tram/eventuate-tram-sagas-examples-customers-and-orders#64 (Swagger UI is returning 404). Is there any chance you could try out the BUILD-SNAPSHOTS with your application? |
@cer |
What's published are Maven repository: |
@kaiocezar how is it going? |
Hi @cer , sorry for the delay, |
As I skipped the version from 29 to 33, I believe I'm missing a column in the message, I'll do it now and test it here. |
@kaiocezar Time has flown. How is it going with Spring Boot 3? |
Hi, @cer! I don't see |
SNAPSHOTS are published to https://snapshots.repositories.eventuate.io/repository However, we've released a version of Eventuate that supports Spring 3 (and Spring Boot 2): eventuatePlatformVersion=2023.1.RELEASE |
No description provided.