-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVPROD-5139: Combine Storybook config #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are some other things that could be exported by the shared addons package in the future? Could it be any tooling that's used between Spruce and Parsley storybook or something more specific?
const GlobalStyles = () => ( | ||
<Global | ||
styles={css` | ||
${fontStyles} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this fontStyles be deleted because of preview-head.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This GlobalStyles component is only used by the application itself, not Storybook, so removing these fontStyles
would remove the font styling from the app.
@@ -10,8 +10,7 @@ const resetStyles = css` | |||
} | |||
`; | |||
|
|||
const globalStyles = css` | |||
${fontStyles} | |||
export const globalStyles = css` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have 1 globalStyles for spruce and parsley?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes—but I think this is not too pertinent to Storybook actually and can be done as followup work for the shared library. I added a comment to DEVPROD-5148!
There is the whole Addon API to leverage, and honestly I think we've barely scratched the surface of what it can do! But also, I think we can export any Storybook-related util functions. (One good candidate is the snapshot script but I think that may be easier once @evg-ui/lib is a little more fleshed out with our test_util functions) |
DEVPROD-5139
Description
@evg-ui/lib
jackspeak
dependency resolution is a workaround for this Storybook bugTesting
@evg-ui/lib