DEVPROD-8016: E2E tests for Sectioning #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
requested changes
Oct 1, 2024
| cy.clickToggle("sections-toggle", false, "log-viewing"); | ||
| cy.dataCy("section-header").should("not.exist"); | ||
| }); | ||
| it("Clicking 'Open all subsections' opens all subsections", () => { |
There was a problem hiding this comment.
This checks that the button updates, can we check the sections themselves are open?
| "Click to open section", | ||
| ); | ||
| }); | ||
| it("Clicking 'Close all subsections' opens all subsections", () => { |
There was a problem hiding this comment.
Same as above but opposite 😁
Comment on lines
5
to
6
| }); | ||
| it("Toggling the sections options displays and hides sections", () => { |
There was a problem hiding this comment.
Super nit but I do appreciate when there are newlines between test blocks for scannability
sophstad
reviewed
Oct 1, 2024
| @@ -12,7 +12,7 @@ interface Props { | |||
| } | |||
| const CaretToggle: React.FC<Props> = ({ onClick, open }) => ( | |||
| <IconButton | |||
| aria-label="Click to open or close section" | |||
| aria-label={`Click to ${open ? "close" : "open"} section`} | |||
There was a problem hiding this comment.
I believe aria-label attributes should omit the interaction instructions
Suggested change
| aria-label={`Click to ${open ? "close" : "open"} section`} | |
| aria-label={`${open ? "Close" : "Open"} section`} |
sophstad
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-8016
These code changes add Cypress for Sectioning.