Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix docs to actually refer to the correct package #218

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

ThisIsMissEm
Copy link
Contributor

It turns out that the lefthook package is actually a fake, and shouldn't be run, instead you'd want this change.

It turns out that the lefthook package is actually a fake, and shouldn't be run, instead you'd want this change.
@ThisIsMissEm
Copy link
Contributor Author

The wiki also needs to be updated to mention how to uninstall husky: https://github.com/evilmartians/lefthook/wiki/Migration-from-husky

Specifically the git config --unset core.hooksPath because husky messes with that.

@Envek Envek merged commit bf2fa19 into evilmartians:master Aug 3, 2021
@Envek
Copy link
Member

Envek commented Aug 3, 2021

Awesome! Thank you!

Interesting that npx lefthook run pre-commit works on my machine because I have lefthook installed from system package manager:

$ npx which lefthook                  
/usr/bin/lefthook

@Envek
Copy link
Member

Envek commented Aug 3, 2021

Also edited wiki. Thanks again!

@ThisIsMissEm
Copy link
Contributor Author

Yeah, I'm not sure exactly what npx is doing there; it was working on my machine, but I thought I was getting trolled by the owner of the lefthook package on npm because weird husky stuff was happening (turned out they'd messed with the gitHooks path)

@ThisIsMissEm
Copy link
Contributor Author

I've also submitted a ticket to npm about potentially getting the lefthook package name unscoped, as it's currently unused and there's lots that references it incorrectly

PikachuEXE added a commit to PikachuEXE/lefthook that referenced this pull request Sep 29, 2021
Envek pushed a commit that referenced this pull request Oct 2, 2021
Envek pushed a commit that referenced this pull request Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants