Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for interactive commands and scripts #352

Conversation

mrexox
Copy link
Member

@mrexox mrexox commented Nov 4, 2022

Closes #125

🔧 Summary

  • Don't use PTY if interactive option is set.
  • Don't run interactive commands/scripts in parallel

Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
@mrexox mrexox marked this pull request as ready for review November 4, 2022 09:49
@mrexox mrexox merged commit 06b4a04 into evilmartians:master Nov 4, 2022
@mrexox mrexox deleted the fix/full-support-for-interactive-commands-and-scripts branch November 4, 2022 09:55
mrexox added a commit that referenced this pull request Nov 4, 2022
Fixed `interactive` feature with parallel execution. Also now we don't suppress STDOUT and correctly redirect STDIN to TTY.

May not work for Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support interactive commands
1 participant