Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-pager flag to brakeman #40

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Add --no-pager flag to brakeman #40

merged 1 commit into from
Aug 1, 2019

Conversation

jaydorsey
Copy link
Contributor

I followed the configuration/setup for Ruby, and have the following lefthook.yml config:

---
pre-commit:
  commands:
    brakeman:
      run: bundle exec brakeman

I noticed that brakeman "gets stuck":

image

I tried a number of flags (parallel, output, debug, bundler, no bundler, etc.) but I think the cause is the default paging behavior which the brakeman docs note here:

By default, Brakeman pages output to the terminal with the less pager. To have Brakeman output directly to terminal, use brakeman --no-pager

I thought this might be a useful improvement to the docs in case anyone else runs into this

I'm running macOS Mojave, brakeman 4.6.1 (via gem install), lefthook 0.6.3 (via gem install), ruby 2.6.3

@Arkweid
Copy link
Collaborator

Arkweid commented Aug 1, 2019

Thank you @jaydorsey. This is a good point.

@Arkweid Arkweid merged commit 3bae20d into evilmartians:master Aug 1, 2019
@jaydorsey jaydorsey deleted the jay/ruby_docs branch August 2, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants