Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip printing deprecation warning #674

Merged

Conversation

mrexox
Copy link
Member

@mrexox mrexox commented Mar 13, 2024

🧹 Summary

Fix skip_settings related to summary, success and failure logging. Skipping summary skips failure and success.

mrexox added 2 commits March 13, 2024 10:31
Deprecation warning doesn't make sense yet, since skip_output is a
useful option. We can deprecate it later when we decide to move away
from it
@mrexox mrexox marked this pull request as ready for review March 13, 2024 07:45
@mrexox mrexox merged commit 96a206e into evilmartians:master Mar 13, 2024
12 of 15 checks passed
@mrexox mrexox deleted the chore/skip-printing-deprecation-warning branch March 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant