chore(cachemulti): add Copy method #52

0xstepit · 2024-07-01T17:04:40Z

Add a deep copy method to the store.

coderabbitai · 2024-07-01T17:04:50Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tip

Early access features: enabled

We are currently testing the following features in early access:

OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
Please join our Discord Community to provide feedback and report issues.
OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

GAtom22

LGTM! Thanks @0xstepit !

CHANGELOG.md

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

store/cachekv/store.go

+	for key, val := range store.cache {
+		newVal := *val // Create a copy of the cValue
+		cacheCopy[key] = &newVal
+	}


store/cachekv/store.go

+	for key := range store.unsortedCache {
+		unsortedCacheCopy[key] = struct{}{}
+	}


store/cachemulti/store.go

+	for key, store := range cms.stores {
+		store, ok := store.(*cachekv.Store)
+		if ok {
+			newStores[key] = store.Copy()
+		}
+	}


store/cachemulti/store.go

+	for key, value := range cms.keys {
+		newKeys[key] = value
+	}


Co-authored-by: tom <tomasguerraalda@hotmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

chore(cachemulti): add Copy method

07b89c9

0xstepit changed the base branch from main to evmos/v0.47.12 July 1, 2024 17:05

0xstepit changed the title ~~stepit/copy method~~ chore(cachemulti): add Copy method Jul 1, 2024

0xstepit marked this pull request as ready for review July 1, 2024 17:08

github-actions bot added the C:Store label Jul 1, 2024

update changelog

b4580c6

0xstepit force-pushed the stepit/copy-method branch from 5af2238 to b4580c6 Compare July 1, 2024 17:09

GAtom22 approved these changes Jul 1, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

c8cc43d

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

0xstepit merged commit 782b016 into evmos/v0.47.12 Jul 1, 2024
6 of 12 checks passed

0xstepit deleted the stepit/copy-method branch July 1, 2024 17:18

github-advanced-security bot found potential problems Jul 1, 2024

View reviewed changes

GAtom22 added a commit that referenced this pull request Jul 18, 2024

chore(cachemulti): add Copy method (#52)

18e04e3

Co-authored-by: tom <tomasguerraalda@hotmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

GAtom22 added a commit that referenced this pull request Jul 30, 2024

chore(cachemulti): add Copy method (#52)

6e4084b

Co-authored-by: tom <tomasguerraalda@hotmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

GAtom22 added a commit that referenced this pull request Aug 7, 2024

chore(cachemulti): add Copy method (#52)

58577b9

Co-authored-by: tom <tomasguerraalda@hotmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(cachemulti): add Copy method #52

chore(cachemulti): add Copy method #52

0xstepit commented Jul 1, 2024 •

edited

Loading

coderabbitai bot commented Jul 1, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

GAtom22 left a comment

chore(cachemulti): add Copy method #52

chore(cachemulti): add Copy method #52

Conversation

0xstepit commented Jul 1, 2024 • edited Loading

coderabbitai bot commented Jul 1, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

GAtom22 left a comment

Choose a reason for hiding this comment

0xstepit commented Jul 1, 2024 •

edited

Loading

coderabbitai bot commented Jul 1, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)