Remove unbound labels from added custom tendermint metrics (#1434)

* Remove unbound labels from added custom tendermint metrics * Add entry to changelog
evmos · Nov 20, 2022 · 391cfa9 · 391cfa9
1 parent f70dafd
commit 391cfa9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -91,6 +91,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (rpc) [#1431](https://github.com/evmos/ethermint/pull/1431) Align hex-strings proof fields in `eth_getProof` as Ethereum.
 * (proto) [#1466](https://github.com/evmos/ethermint/pull/1466) Fix proto scripts and upgrade them to mirror current cosmos-sdk scripts
 * (rpc) [#1405](https://github.com/evmos/ethermint/pull/1405) Fix uninitialized chain ID field in gRPC requests.
+* (analytics) [#1434](https://github.com/evmos/ethermint/pull/1434) Remove unbound labels from custom tendermint metrics.
 
 ## [v0.19.3] - 2022-10-14
 

diff --git a/x/evm/keeper/msg_server.go b/x/evm/keeper/msg_server.go
@@ -32,15 +32,11 @@ func (k *Keeper) EthereumTx(goCtx context.Context, msg *types.MsgEthereumTx) (*t
 
 	labels := []metrics.Label{
 		telemetry.NewLabel("tx_type", fmt.Sprintf("%d", tx.Type())),
-		telemetry.NewLabel("from", sender),
 	}
 	if tx.To() == nil {
-		labels = []metrics.Label{telemetry.NewLabel("execution", "create")}
+		labels = append(labels, telemetry.NewLabel("execution", "create"))
 	} else {
-		labels = []metrics.Label{
-			telemetry.NewLabel("execution", "call"),
-			telemetry.NewLabel("to", tx.To().Hex()), // recipient address (contract or account)
-		}
+		labels = append(labels, telemetry.NewLabel("execution", "call"))
 	}
 
 	response, err := k.ApplyTransaction(ctx, tx)