tx which failed in deliverTx could deduct fee but can't be found

[yihuang]

Proposal: Support receipt for failed transaction

Current behavior:

Currently failed transactions in block are ignored in json-rpc API due to implementation difficulties, ideally we should support them, because those tx also deduct fee and increase nonce from sender, user'll need to discover those tx in json-rpc apis.

The main difficulty was the lack of eth tx hash event for failed tx, so JSON-RPC can't find the cosmos tx by eth tx hash using the /tx_search API, but cosmos-sdk 0.45 supports emitting event even for failed tx in ante handlers. so it's possible to support this now I think.

A common cause for such failed tx is out of block gas limit.

Desired behavior: [What you would like to happen]

Use case: [Why is this important (helps with prioritizing requests)]

Requests may be closed if we're not actively planning to work on them.

[yihuang]

There are two kinds of deliverTx failure:

• failed in ante handler, fee/nonce not changed, ok to ignore.
• failed in message handler, fee/nonce changed, should not skip. Most of failure cases are already checked before execution, remaining ones are:
  • EnableCreate/EnableCall check, we should move the check into ante handler.
  • exceed block gas limit, we should handle this failure case in RPC api to return a receipt somehow.

[yihuang]

fixed by #1062