Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Identify usage of GetBaseFeeV1 #1562

Closed
Vvaradinov opened this issue Dec 19, 2022 · 1 comment
Closed

Identify usage of GetBaseFeeV1 #1562

Vvaradinov opened this issue Dec 19, 2022 · 1 comment

Comments

@Vvaradinov
Copy link
Contributor

Vvaradinov commented Dec 19, 2022

The current param BaseFee defaults to a "version 1" of the parameter if there is no BaseFee set as follows:

// GetBaseFee gets the base fee from the store
func (k Keeper) GetBaseFee(ctx sdk.Context) *big.Int {
	params := k.GetParams(ctx)
	if params.NoBaseFee {
		return nil
	}

	baseFee := params.BaseFee.BigInt()
	if baseFee == nil || baseFee.Sign() == 0 {
		// try v1 format
		return k.GetBaseFeeV1(ctx)
	}
	return baseFee
}

With the migration of params PR can we now safely delete the BaseFeeV1 param?

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant