-
Notifications
You must be signed in to change notification settings - Fork 562
chore(feemarket) - Depreacte usage of x/params in x/feemarket #1509
Conversation
….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
==========================================
- Coverage 68.40% 68.19% -0.21%
==========================================
Files 106 110 +4
Lines 10077 10087 +10
==========================================
- Hits 6893 6879 -14
- Misses 2783 2801 +18
- Partials 401 407 +6
|
….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Vvaradinov!! Left a few questions and comments, LMK your thoughts
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
….com/evmos/ethermint into Vvaradinov/refactor-feemarket-params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Good stuff @Vvaradinov, left some small comments
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should improve coverage in the msg.go file
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vvaradinov requesting some additional changes that we discussed in Slack
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Deprecates the now legacy Cosmos SDK
x/params
usage inx/feemarket
module. For more info regarding changes check out #1472Closes: ENG-1107
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)