Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: evm debugging message displayed with fatal log option #286

Closed
leejw51crypto opened this issue Jul 14, 2021 · 5 comments
Closed
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@leejw51crypto
Copy link
Contributor

leejw51crypto commented Jul 14, 2021

i run ethermind like this

ethermintd start --pruning=nothing --keyring-backend $KEYRING --log_level fatal

but debugging logs are still visible.
make it silent when specified with info, fatal option.
only make it visible with debug option

ref: https://github.com/tharsis/ethermint/blob/main/server/start.go#L240
override LogHandler

@fedekunze
Copy link
Contributor

yeah, ideally we should override the ethlog.Root() for the SDK logger that wraps the ethereum logger interface so that we can update the log level

@fedekunze fedekunze added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 14, 2021
@leejw51crypto
Copy link
Contributor Author

almost done, refactoring now

@leejw51crypto leejw51crypto self-assigned this Jul 20, 2021
@khoslaventures
Copy link
Contributor

Fwiw, the sdk has had a lot of issues with too much logging: cosmos/cosmos-sdk#8132

Is there something we can upstream here?

I would also love to see some better docs in general on how to leverage log-level, since there are a lot of helpful options for filtering the logs, for example:
https://blog.8bitzen.com/posts/29-08-2019-understanding-the-cosmos-daemon-output-and-changing-the-log-level

And this is not really covered well in the docs.

@leejw51crypto
Copy link
Contributor Author

yes, log itself can cause some issues, if it's generated too fast

@leejw51crypto
Copy link
Contributor Author

already done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants